Skip to:

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6505 closed defect (bug) (fixed)

Separate actions and screens in Messages component

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: 1.0
Component: Messages Keywords: needs-patch


Two screen functions also contain actions:

  • messages_screen_compose() sends a private message
  • messages_screen_notices() sends notices

Change History (3)

#1 @johnjamesjacoby
9 years ago

The actionable functionality in these components should be moved into bp-messages-actions.php and hooked to bp_actions.

#2 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9947:

Messages: Separate actions from screen functions

This change extracts action-specific functionality from 2 message specific screen functions (per the component coding standards) by introducing two new functions in bp-messages-actions.php and hooking them to bp_actions. These new functions handle the creation of new private messages and notices, and the editing & deletion of existing notices.

A few additional improvements were also made to these functionalities:

  • String improvements to provide additional clarity to site members performing message related actions
  • Code scrutinization and documentation improvements to better understand what these functions are for and when they were introduced
  • Updates to new helper functions introduced since these functions were first introduced and last updated

Fixes #6505 (in trunk, for 2.4)

#3 @r-a-y
9 years ago

In 9966:

Messages: Add phpDoc clarification about message action functions.

See #6505.

Note: See TracTickets for help on using tickets.