Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6485 closed defect (bug) (fixed)

new_blog_comment dropdown filter, the just-me scope and heartbeat activities when comment sync is on

Reported by: imath Owned by: imath
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.1
Component: Blogs Keywords: has-patch commit needs-refresh
Cc:

Description

While working on #6482, i've also notice that when comment sync is on:

  • the bp_blogs_new_blog_comment_query_backpat() fails to get activity_comments that are generated when a post is commented when on the just-me scope.
  • when on the activity directory, there is some duplicate content, and more annoying the heartbeat feature is displaying the load newest link each 30s although there's no new_blog_comment activity. The reason of the hertabeat trouble is that the filter _bp_blogs_new_blog_comment_query_backpat_filter is building a query that doesn't order the activities in the right order.

I suggest to use BP_Activity_Query instead of the filter to solve the issue.

Attachments (2)

6485.patch (4.3 KB) - added by imath 4 years ago.
6485.02.patch (3.6 KB) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (7)

@imath
4 years ago

@imath
4 years ago

#1 @imath
4 years ago

In 01.patch i was adding a not needed parameter, 02.patch corrects this and keeps the 'stream' display comments mode.

#2 @r-a-y
4 years ago

  • Keywords commit added

Nice work, imath!

One tiny suggestion, perhaps remove the if ( bp_disable_blogforum_comments() ) { block. This isn't included currently in bp_blogs_new_blog_comment_query_backpat().

#3 @imath
4 years ago

Thanks for your feedback r-a-y :) Will remove the bp_disable_blogforum_comments() check, and will commit it asap.

Last edited 4 years ago by imath (previous) (diff)

#4 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 9958:

Blogs: make sure filtering activities by the new_blog_comment action gets the corresponding entries on the just-me scope and that these entries are ordered DESC by date.

When activity comments are synced with blog post comments, and when the activity filter is set to new_blog_comment :

  • while browsing the activities in the profile of a user, no activities were fetched.
  • while browsing the activity directory, the heartbeat feature kept on generating the "Load newest" link although no new activities were posted.

Using a specific BP_Activity_Query is fixing both issues.

Fixes #6485

#5 @Maniou
4 years ago

  • Keywords needs-refresh added

Hi @imath,
Whith thoses changes is not possible to use the bp_ajax_querystring filter to be able to filter the activity loop with the action new_blog_comment and others actions (in the just-me scope). Like it's described here : https://codex.buddypress.org/developer/function-examples/bp_ajax_querystring/ . The comments are not displaying anymore.
Do you have an idea to fix this problem ?
Thanks :)

Last edited 4 years ago by Maniou (previous) (diff)
Note: See TracTickets for help on using tickets.