#6485 closed defect (bug) (fixed)
new_blog_comment dropdown filter, the just-me scope and heartbeat activities when comment sync is on
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 2.4 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Blogs | Keywords: | has-patch commit needs-refresh |
Cc: |
Description
While working on #6482, i've also notice that when comment sync is on:
- the
bp_blogs_new_blog_comment_query_backpat()
fails to get activity_comments that are generated when a post is commented when on the just-me scope. - when on the activity directory, there is some duplicate content, and more annoying the heartbeat feature is displaying the load newest link each 30s although there's no new_blog_comment activity. The reason of the hertabeat trouble is that the filter
_bp_blogs_new_blog_comment_query_backpat_filter
is building a query that doesn't order the activities in the right order.
I suggest to use BP_Activity_Query
instead of the filter to solve the issue.
Attachments (2)
Change History (7)
#2
@
9 years ago
- Keywords commit added
Nice work, imath!
One tiny suggestion, perhaps remove the if ( bp_disable_blogforum_comments() ) {
block. This isn't included currently in bp_blogs_new_blog_comment_query_backpat()
.
#3
@
9 years ago
Thanks for your feedback r-a-y :) Will remove the bp_disable_blogforum_comments()
check, and will commit it asap.
#4
@
9 years ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 9958:
#5
@
9 years ago
- Keywords needs-refresh added
Hi @imath,
Whith thoses changes is not possible to use the bp_ajax_querystring filter to be able to filter the activity loop with the action new_blog_comment and others actions (in the just-me scope). Like it's described here : https://codex.buddypress.org/developer/function-examples/bp_ajax_querystring/ . The comments are not displaying anymore.
Do you have an idea to fix this problem ?
Thanks :)
In 01.patch i was adding a not needed parameter, 02.patch corrects this and keeps the 'stream' display comments mode.