jcrop aspect ratio isn't properly pulling in height/width constants from bp-custom.php

[studio625]

When I define a non-square aspect ratio in bp-custom.php, the jcrop interface doesn't correctly constrain the aspect ratio. If I hardcode it in, it works fine, so something is breaking down when BP hands it over to jcrop.

Here's my bp-custom code:

define ( 'BP_AVATAR_FULL_WIDTH', 328 );
define ( 'BP_AVATAR_FULL_HEIGHT', 437 );

Here's how I've been fixing it in BP < 2.3

Original Code (around line 223 of bp-core-cssjs.php:

aspectRatio: <?php echo (int) $aspect_ratio; ?>,

Modified Code:

aspectRatio: <?php echo $aspect_ratio; ?>,

(basically, don't cast it into an integer.

How I fixed it in BP 2.3
With the 2.3 release, the avatar cropping interface is different. I haven't figured out a solution other than hardcoding the aspect ratio into bp-core/js/avatar.js:

aspectRatio: 328 / 437,

[imath]

Ok thanks for your feedback i'll look at it asap.

[imath]

Ok it looks like i'm building the aspect ratio the wrong way. I think 6479.patch should fix the issue.

Can you confirm @studio625 ?

[studio625]

Yep, that did it!

Thanks :)

[imath]

Thanks for your confirmation, i'll commit the patch asap :)

[imath]

In 9920:

Avatar UI: make sure the cropper is using the correct aspect ratio.

See #6479 (branch 2.3)

Props studio625

[imath]

In 9921:

Avatar UI: make sure the cropper is using the correct aspect ratio.

Fixes #6479 (trunk)

Props studio625

[binh]

I'm facing this exact problem at version 2.3.2.1. Saw the code appear exactly lik in 9921 fixed, but it's still showing height/width ratio. Maybe something deeper?

Update: I found out it's the avatar.min.js file causing the problem, not the avatar.js file.