Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6472 closed defect (bug) (fixed)

Duplicate IDs in Profile Fields Admin Panel

Reported by: mercime Owned by: DJPaul
Milestone: 2.4 Priority: normal
Severity: normal Version: 1.7
Component: Extended Profile Keywords: has-patch early good-first-bug needs-testing
Cc:

Description

Attached patch removes IDs generated in fieldsets to fix issue.

Attachments (1)

xprofile.diff (655 bytes) - added by mercime 5 years ago.

Download all attachments as: .zip

Change History (7)

@mercime
5 years ago

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


5 years ago

#2 @johnjamesjacoby
5 years ago

  • Component changed from API to Component - XProfile
  • Keywords early added
  • Milestone changed from Awaiting Review to 2.4
  • Version set to 1.7

See also:

  • BP_XProfile_Field_Type::get_edit_field_html_elements();
  • bp_get_form_field_attributes()

Patch looks good, but isn't a regression so moving to 2.4.

Can we double-plus confirm that nothing in the CSS or JS looks for any of these fieldset ID's?

#3 @DJPaul
5 years ago

  • Keywords good-first-bug added

#4 @DJPaul
5 years ago

  • Keywords needs-testing added

Needs a test before we can commit this, then we can keep an eye out for any further issues during 2.4 dev.

#5 @DJPaul
5 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

Please leave this ticket for me to commit.

I'll get it done later this week.

#6 @mercime
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10071:

Remove duplicate IDs from xProfiles admin screen.

Duplicate id values are generated in both the fieldset and in any of the
associated form control elements in the Profile Fields admin screen. The id
value is required for all form controls to be associated with label tags
while the ‘id value for the fieldset` element on the other hand is not
used in either the Profile Fields admin CSS nor JS. Removing the id attribute
from the fieldset element fixes the issue of duplicate ids in the DOM .

Props mercime, boonebgorges, djpaul, johnjamesjacoby.
Fixes #6472.

Note: See TracTickets for help on using tickets.