Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #6457, comment 12


Ignore:
Timestamp:
05/31/2015 07:16:41 PM (6 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6457, comment 12

    v1 v2  
    33`01.patch` gets us back to what we were doing since 2.1.1 (#5888), which is not looking for minified assets in parent and child themes.
    44
    5 The main issue I have with `02.patch` -- looking for another `.min` asset in the stack -- is this adds a maximum of two more `file_exists()` calls for each asset check.  Multiply that by 4 if we count every single call to `locate_asset_in_stack()`.  Multiply that by 6 if the site is RTL.
     5The main issue I have with `02.patch` -- looking for another `.min` asset in the stack -- is this adds a maximum of six more `file_exists()` calls for each asset check.  Multiply that by 4 if we count every single call to `locate_asset_in_stack()`.  Multiply that by 6 if the site is RTL.
    66
    77Most themes will not be overriding our assets with a minified CSS file / JS file.  If there are themes that do, they probably will have already made this change in their build environments since we've added asset stack checks since v1.9 (#4949).  In this case, we'd be adding another `.min` asset check for no reason.