#6436 closed defect (bug) (fixed)
Untranslated date on admin Activity UI - missing i18n
Reported by: | danbp | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.4 | Priority: | high |
Severity: | normal | Version: | 2.2.3 |
Component: | I18N | Keywords: | good-first-bug has-patch |
Cc: | danco38@… |
Description
In french, the date looks like this on the admin activity page
Soumis le 14 May 2015 à 18 h 15 min
Soumis le 5 February 2015 à 3 h 20 min
etc...
To solve the problem, I replaced in bp-activity-admin.php:1531
printf( __( 'Submitted on <a href="%1$s">%2$s at %3$s</a>', 'buddypress' ), bp_activity_get_permalink( $item['id'] ), get_date_from_gmt( $item['date_recorded'], get_option( 'date_format' ) ), get_date_from_gmt( $item['date_recorded'], get_option( 'time_format' ) ) );
by
printf( __( 'Submitted on <a href="%1$s">%2$s at %3$s</a>', 'buddypress' ), bp_activity_get_permalink( $item['id'] ), date_i18n( get_option( 'date_format' ) , strtotime( $item['date_recorded'] ) ), get_date_from_gmt( $item['date_recorded'], get_option( 'time_format' ) ) );
Not sure if it's the best, but at least, it is working.
Digged a bit on Trac before posting and found #5781 - in case of.
Good catch! Let's audit all of these for 2.4 and fix them.