Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#6427 closed defect (bug) (fixed)

Sites Directory Index Template Form Nesting

Reported by: hnla Owned by: johnjamesjacoby
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

Sites Directory template appears to still have an instance of nested forms, the primary form is positioned just after the opening #buddypress element and thus includes as a child the dir-search form, in the other templates we open the primary form just before the item-list-tabs.

Apart from being simply wrong, this has issues for my companion styles dir-search which expects the form element to be following it and the layout is disrupted as a consequence.

I had though we had caught and dealt with all these nested form instances.

Patch move the opening form element to match other directory templates just before the list-tabs start.

With thanks to imath for spotting this.

Attachments (1)

6427.01.patch (5.4 KB) - added by hnla 5 years ago.

Download all attachments as: .zip

Change History (8)

@hnla
5 years ago

#1 @DJPaul
5 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#2 @DJPaul
5 years ago

  • Owner DJPaul deleted

I can't test this because I'm not currently running a multisite in my dev env.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


5 years ago

#4 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby

I'll look at this today for 2.3.0.

#5 @johnjamesjacoby
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9890:

Directories: Normalize blogs, members, and groups index.php directory templates.

This changeset specifically addresses nested forms in the blogs directory template, and also removes closing PHP tags at the bottom of the members and groups templates.

Props hnla. Fixes #6427.

#6 @johnjamesjacoby
5 years ago

In 9891:

Blogs: Update hook documentation for bp_before_directory_blogs and bp_before_directory_blogs_tabs

See #6427. See r9890.

#7 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.