Sites Directory Index Template Form Nesting

[hnla]

Sites Directory template appears to still have an instance of nested forms, the primary form is positioned just after the opening #buddypress element and thus includes as a child the dir-search form, in the other templates we open the primary form just before the item-list-tabs.

Apart from being simply wrong, this has issues for my companion styles dir-search which expects the form element to be following it and the layout is disrupted as a consequence.

I had though we had caught and dealt with all these nested form instances.

Patch move the opening form element to match other directory templates just before the list-tabs start.

With thanks to imath for spotting this.

[DJPaul]

I can't test this because I'm not currently running a multisite in my dev env.

[johnjamesjacoby]

I'll look at this today for 2.3.0.

[johnjamesjacoby]

In 9890:

Directories: Normalize blogs, members, and groups index.php directory templates.

This changeset specifically addresses nested forms in the blogs directory template, and also removes closing PHP tags at the bottom of the members and groups templates.

Props hnla. Fixes #6427.

[johnjamesjacoby]

In 9891:

Blogs: Update hook documentation for bp_before_directory_blogs and bp_before_directory_blogs_tabs

See #6427. See r9890.