Skip to:

Opened 9 years ago

Closed 9 years ago

#6420 closed defect (bug) (fixed)

Cannot set properties of BP_Activity_Feed object

Reported by: needle's profile needle Owned by: r-a-y's profile r-a-y
Milestone: 2.4 Priority: normal
Severity: normal Version: 1.8
Component: Activity Keywords: has-patch


Although class BP_Activity_Feed has the bp_activity_feed_prefetch filter, it doesn't seem possible to alter the passed object because it has no "magic" setter method. Patch attached.

Attachments (1)

6420.patch (633 bytes) - added by needle 9 years ago.

Download all attachments as: .zip

Change History (8)

9 years ago

#1 @needle
9 years ago

  • Keywords has-patch added
  • Summary changed from Cannot set properties of class BP_Activity_Feed to Cannot set properties of BP_Activity_Feed object

#2 @boonebgorges
9 years ago

This looks right to me, but it would be nice to see if @r-a-y had anything specific in mind when making $data protected. Maybe we need to blacklist some keys?

#3 @DJPaul
9 years ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to Under Consideration

#4 @DJPaul
9 years ago

Ping @r-a-y :)

#5 @DJPaul
9 years ago

Pinging @r-a-y again: i'd like to close this if it were intentional, or put it into 2.4.

#6 @r-a-y
9 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Under Consideration to 2.4
  • Version set to 1.8

needle is right. This is something I initially overlooked.

Sorry for missing this ticket several times :)

#7 @r-a-y
9 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10094:

Activity: Allow RSS to be modified on the 'bp_activity_feed_prefetch' action.

The BP_Activity_Feed' class was missing the magic set()` method, making
overriding existing feed properties impossible.

Props needle.

Fixes #6420.

Note: See TracTickets for help on using tickets.