Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6418, comment 4


Ignore:
Timestamp:
05/05/2015 04:01:32 PM (10 years ago)
Author:
boonebgorges
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6418, comment 4

    initial v1  
    11@lakrisgubben - Cool, this is looking closer.
    22
    3 Here are some unit tests you can use as a starting point: https://buddypress.trac.wordpress.org/browser/tags/2.2.0/tests/phpunit/testcases/core/class-bp-user-query.php#L410 Tests needed: (a) show that 'member_type__in' works, (b) show that 'member_type' overrides 'member_type__in', (c) show that 'member_type__not_in' returns members both members from types other than those specified, as well as members that have no member type at all, (d) show that 'member_type__not_in' and 'member_type' work together in a sane way, (e) show that 'member_type__not_in' returns an empty set in the proper cases. :-D
     3Here are some unit tests you can use as a starting point: https://buddypress.trac.wordpress.org/browser/tags/2.2.0/tests/phpunit/testcases/core/class-bp-user-query.php#L410 Tests needed: (a) show that `'member_type__in'` works, (b) show that `'member_type'` overrides `'member_type__in'`, (c) show that `'member_type__not_in'` returns members both members from types other than those specified, as well as members that have no member type at all, (d) show that `'member_type__not_in'` and `'member_type'` work together in a sane way, (e) show that `'member_type__not_in'` returns an empty set in the proper cases. :-D
    44
    55I'm not sure I understand what's going on with the regex, but I'll take a look myself once there are some unit tests that make it a bit easier to test.