Changes between Version 3 and Version 4 of Ticket #6388, comment 20
- Timestamp:
- 10/02/2015 07:26:21 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #6388, comment 20
v3 v4 1 1 > The change you suggest would break plugins that expect bp_is_group_home() to report whether you're looking at example.com/groups/foo/, with no bp_current_action(). 2 2 3 If you are on `example.com/groups/foo/` the current action is `'home'`, so that wouldn't break any checks to see if `bp_current_action()` is empty.3 If you are on `example.com/groups/foo/`, the current action is `'home'`, so that wouldn't break any checks to see if `bp_current_action()` is empty. 4 4 5 5 > One thing that would make things easier is if example.com/groups/foo/, with 'activity' set to the home page, made it true that bp_is_group_activity(). It doesn't do that, because it'd mean manually setting the current_action during BP_Groups_Component::setup_globals(). Is there any reason we can't do this?