Fix for bp_groups-template in order to support Ajax for group admin actions

[lenasterg]

Hi.
The attached patch allows the current group to be fetched for manage members actions(ban, unban, promote etc).
This would allow us in 2nd phase to use Ajax also in group members management similar to ​https://buddypress.trac.wordpress.org/ticket/5440.

[DJPaul]

Thanks for the patch. Looks OK. Haven't tested it yet.

[DJPaul]

I really want to sneak this in as it looks like a trivial change, I'll take a look at it this weekend.

[DJPaul]

Looks a bit more involved than at first glance. Let's do for 2.4.

[lenasterg]

This ticket is related to ​https://buddypress.trac.wordpress.org/ticket/6385.

[r-a-y]

bp-groups-template.php.patch has the potential to break links for those relying on the $groups_template global.

Instead, 01.patch sets the $group object to groups_get_current_group() after the group check in $groups_template does not exist for all our group template functions.

This should allow us to use group template functions across all group contexts now, which is something I've wanted to do for awhile now.

lenasterg - Does this work for you?

I'll split the changes to add a second parameter for bp_group_member_demote_link(), bp_group_member_ban_link(), bp_group_member_unban_link() and bp_group_member_remove_link() into a separate commit.

[lenasterg]

Hi @r-a-y.
Yes the 6387.01 patch works fine for me.
If you include to src I can move forward and commit patch for the ticket ​https://buddypress.trac.wordpress.org/ticket/6385.

Thanks Lena.

[DJPaul]

I see some sneaky changes for extract, let's commit those lines seperately.

RE: $groups_template->group vs groups_get_current_group(). I think these returns different objects. Did you check? I think I did and found they were different which is why I left my "this looks more involved than at first glance" comment.

[DJPaul]

Patch needs some refactoring.

[DJPaul]

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see ​https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: ​https://make.wordpress.org/chat/