Skip to:
Content

Opened 3 years ago

Closed 22 months ago

#6385 closed enhancement (fixed)

No group members search in groupname/admin/manage-members/

Reported by: lenasterg Owned by: dcavins
Milestone: 2.7 Priority: normal
Severity: normal Version: 1.1
Component: Groups Keywords:
Cc:

Description

Hi.
I noticed that a group administrator has no posibility to search for a member in groupName/admin/manage-members/ page.
So for large groups (more than 200) the user management is very hard.
Is the /* Manage Group Members */ section in
bp-templates/bp-legacy/buddypress/groups/single/admin.php the right place to start working a solution?

Attachments (2)

6385.1.patch (1.9 KB) - added by dcavins 2 years ago.
Adds a search form to the manage members screen. Works best with the changes suggested in #7105.
6385.2.patch (2.0 KB) - added by dcavins 22 months ago.
Adds a search box to the manage members screen, hooked to the new action introduced in #7249.

Download all attachments as: .zip

Change History (15)

#1 @r-a-y
3 years ago

  • Milestone changed from Awaiting Review to Under Consideration

Is the /* Manage Group Members */ section in bp-templates/bp-legacy/buddypress/groups/single/admin.php the right place to start working a solution?

Yes it is. This would make a great enhancement.

It would be nice to break out all the different functionality in the admin.php template into individual template parts since all of the frontend group admin template code resides there.

If you would like to tackle this for 2.4, lenasterg, please let us know.

In the meantime, moving this to the "Under Consideration" milestone.

#2 @lenasterg
3 years ago

Hi @r-a-y.
Actually, since my ticket here I made a solution.
The solution among other modification uses the patch I submitted at https://buddypress.trac.wordpress.org/ticket/6387. Should I reattach this change also or should I wait the 6387 ticket to get closed and then attach the rest of the modifications here?

#3 @DJPaul
3 years ago

  • Milestone changed from Under Consideration to Future Release

#6387 will happen for 2.5, so we can look at this then.

#4 @dcavins
2 years ago

Note that in the attached patch, I wanted the styling help from the class dir-search but unwired the ajax helper by adding the class no-ajax. Also note that this works better with the changes from #7105, because that ticket adds "no members found" response text when bp_group_has_members() returns an empty set.

@dcavins
2 years ago

Adds a search form to the manage members screen. Works best with the changes suggested in #7105.

#5 @dcavins
22 months ago

  • Milestone changed from Future Release to 2.7
  • Owner set to dcavins
  • Status changed from new to accepted
  • Version set to 1.1

@hnla: Do you have any thoughts on this? I know you've been thinking about this screen in bp-nouveau.

#6 @hnla
22 months ago

@dcavins Yes I did split out the search form to a template part, if that is what we're talking about?

Actually looks as though we're referring to a few changes here that might be done or about done, I'll look closer in the morning.

Groups admin is split though on this ticket:
https://buddypress.trac.wordpress.org/ticket/7079 (and in Nouveau)

Last edited 22 months ago by hnla (previous) (diff)

#7 follow-up: @hnla
22 months ago

@dcavins for the search requirement can we not use:
bp_get_template_part( 'common/search/dir-search-form' );

which would be available when this ticket is committed #6844

#8 in reply to: ↑ 7 @dcavins
22 months ago

Replying to hnla:

@dcavins for the search requirement can we not use:
bp_get_template_part( 'common/search/dir-search-form' );

which would be available when this ticket is committed #6844

@hnla that sounds good, though there're several bp_current_component() usages in the new template part... and since this is a member search in the groups component, it may not work as expected. I'll try it out and get back to you.

#9 @dcavins
22 months ago

@hnla: Ok, probably not. The form created by bp_get_template_part( 'common/search/dir-search-form' ); really thinks it's a group directory search form in this use:

 <form action="" method="get" id="search-groups-form">
  <label for="groups_search" class="bp-screen-reader-text">Search Groups...</label>
    <input type="text" name="groups_search" id="groups_search" placeholder="Search Groups..." />
    <input type="submit" id="groups_search_submit" name="groups_search_submit" value="Search" />
 </form>

So...

#10 follow-up: @hnla
22 months ago

Ok hardcode it then as you have, not worth worrying over I guess.

#11 in reply to: ↑ 10 @dcavins
22 months ago

Replying to hnla:

Ok hardcode it then as you have, not worth worrying over I guess.

I wish there were a way to pass parameters into templates. Not the first time I've wished that.

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


22 months ago

@dcavins
22 months ago

Adds a search box to the manage members screen, hooked to the new action introduced in #7249.

#13 @dcavins
22 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 11070:

Group admin: Add search to manage members screen.

Adds a search form to a single group’s manage members screen. This is
very helpful when managing groups with several hundred members.

Props hnla, dcavins.

Fixes #6385.

Note: See TracTickets for help on using tickets.