Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6361 closed defect (bug) (fixed)

Debug notices in BP_Core_Members_Widget

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.3 Priority: high
Severity: normal Version: 1.2
Component: Members Keywords:
Cc:

Description

The BP_Core_Members_Widget widget produces several debug notices, mostly due to messy implementation of default settings for the widget itself.

The code in this widget is also relatively old and unloved, and due for a refresh.

Change History (3)

#1 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

#2 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 9724:

Members: Improvements to BP_Core_Members_Widget

  • Escape gettext output
  • Yoda conditions
  • Do not check nonce referrer to prevent collisions with other referrer nonces
  • Add missing semicolons after PHP execution
  • Introduce parse_settings() method for setting smart default values
  • Remove extract() usages
  • Code formatting improvements

Fixes #6361.

#3 @johnjamesjacoby
4 years ago

In 9727:

Members: Improvements to BP_Core_Members_Widget's ajax handler:

  • Escape gettext output
  • Add missing semicolons after PHP execution
  • Smarter filter handling and default values
  • Code formatting improvements

See #6361.

Note: See TracTickets for help on using tickets.