Opened 10 years ago
Closed 7 years ago
#6340 closed defect (bug) (fixed)
XProfile Field-Group name save issues
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.4 | Priority: | high |
Severity: | major | Version: | |
Component: | Extended Profile | Keywords: | needs-patch needs-unit-tests |
Cc: |
Description
When saving an XProfile field group name with single quotes, the quotes are saved as slashed.
Editing and saving again slashes the name again, introducing more and more slashes.
Change History (13)
#7
follow-up:
↓ 8
@
10 years ago
Can we start using the third parameter of in_array
? It makes it do a type strict comparison and while that may not help in these instances, I think it's a valuable thing to do as we write new code.
#8
in reply to:
↑ 7
@
10 years ago
Replying to DJPaul:
Can we start using the third parameter of
in_array
? It makes it do a type strict comparison and while that may not help in these instances, I think it's a valuable thing to do as we write new code.
Yes, we can and should.
#10
@
10 years ago
- Milestone changed from 2.3 to 2.4
Bumping this to 2.4.
We will need a database upgrade routine to fix this.
Also, ugh.
This appears to be... accidentally intentional. It has been using incorrect validation and sanitization functions since its inception. Will likely need a few different unit tests to confirm the existing bug, backwards compatibility, and any fixes.