Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#6337 closed defect (bug) (fixed)

Wrong image url on bp-activity-admin.php

Reported by: lenasterg Owned by: r-a-y
Milestone: 2.3 Priority: low
Severity: trivial Version: 1.6
Component: Activity Keywords: good-first-bug has-patch
Cc:

Description

Hi.
I noticed that when using at multisite on activity admin page the image images/wpspin_light.gif appears broken.
This is causes by the bp_get_admin_url() function
at
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-activity/bp-activity-admin.php#L1005

which is search the image at "wp-admin/network/images/" instead of the correct "wp-admin/images/" .

Suggestion fix:

Replace line https://buddypress.trac.wordpress.org/browser/trunk/src/bp-activity/bp-activity-admin.php#L1005 with the following.

<img class="waiting" style="display:none;" src="<?php echo esc_url( get_admin_url() . 'images/wpspin_light.gif' ); ?>" alt="" />

Attachments (1)

6337.diff (828 bytes) - added by pareshradadiya 3 years ago.
bp_get_admin_url is replaced with admin_url

Download all attachments as: .zip

Change History (6)

#1 @DJPaul
3 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 1.6
  • Version 2.2.1 deleted

Good catch

#2 @DJPaul
3 years ago

  • Milestone changed from 1.6 to 2.3
  • Version set to 1.6

@pareshradadiya
3 years ago

bp_get_admin_url is replaced with admin_url

#3 @pareshradadiya
3 years ago

  • Keywords has-patch added

#4 @DJPaul
3 years ago

Hi @pareshradadiya, thanks for the patch! Your first BuddyPress patch, I think? :)

The patch looks OK, we will test it this week and get it committed.

#5 @r-a-y
3 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9841:

Activity Admin: Fix loading image when replying to an item in multisite.

Props lenasterg, pareshradadiya.

Fixes #6337.

Note: See TracTickets for help on using tickets.