Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6321 closed defect (bug) (fixed)

Messages: AJAX replies should use the message loop

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.3 Priority: normal
Severity: normal Version: 1.2
Component: Messages Keywords: has-patch
Cc:

Description

When making a reply to a private message thread, our AJAX message output should use the message loop and all related message template functions.

Currently during AJAX, we do a workaround fix for zebra-striping (see r6548) and we do not use native template functions such as bp_the_thread_message_css_class() (see r8604) or bp_the_thread_message_content() (see r2191).

This is because we're not using the message loop correctly when rendering the AJAX content.

Attached patch emulates the message loop to ensure that the current message in the loop is correctly set. This allows us to use our message template functions without resorting to workarounds.

Attachments (1)

6321.01.patch (2.0 KB) - added by r-a-y 4 years ago.

Download all attachments as: .zip

Change History (3)

@r-a-y
4 years ago

#1 @johnjamesjacoby
4 years ago

A long-standing enhancement in the making.

Nice work!

#2 @r-a-y
4 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9838:

bp-legacy: For AJAX private message reply, use the message loop.

When making a reply to a private message thread, our AJAX message output
should use the message loop and all related message template functions.

Previously, we did a workaround fix for zebra-striping (see r6548) and did
not use native template functions such as bp_the_thread_message_css_class()
(see r8604) or bp_the_thread_message_content() during AJAX.

Fixes #6321.

Note: See TracTickets for help on using tickets.