Skip to:

Opened 9 years ago

Closed 9 years ago

#6319 closed defect (bug) (fixed)

"This is a hidden group" message being incorrect thrown for private groups

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 2.3 Priority: high
Severity: normal Version:
Component: Groups Keywords:


The refactor in [9462] resulted in the "This is a hidden group" message being incorrectly shown in the case of private groups. I'm pretty sure this is just because of a missing break, but I'm going to write some unit tests to demonstrate it one way or another.

Change History (2)

#1 @johnjamesjacoby
9 years ago

Definitely because of the missing break statement on line 2995. Sorry about that.

#2 @boonebgorges
9 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9646:

Bug fixes for bp_group_status_message().

  • The $group parameter passed to the function should be obeyed when doing invite/request checks. Note that this requires that the group objects have been generated with 'populate_extras', or the is_invited etc checks will result in false negatives.
  • Insert missing break that was causing all the hidden group message to be shown for private groups.

Fixes #6319.

Note: See TracTickets for help on using tickets.