Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

#6318 closed defect (bug) (fixed)

Update XProfile UI to better match current WordPress design

Reported by: johnjamesjacoby Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: 1.7
Component: Extended Profile Keywords:
Cc:

Description (last modified by johnjamesjacoby)

With recent improvements to WordPress's administration area UI, and enhancements to menus, widgets, and the customizer, our XProfile UI looks outdated. Thankfully our markup here is pretty flexible, though our (see: my) judicious use of fieldset elements is probably less than ideal.

Attachments (3)

Screen Shot 2015-03-23 at 9.58.33 PM.png (67.0 KB) - added by johnjamesjacoby 5 years ago.
6318-02.patch (1.8 KB) - added by hnla 5 years ago.
zero is zero
6318-03.patch (2.4 KB) - added by hnla 5 years ago.
Add tab animation colour change and opacity

Download all attachments as: .zip

Change History (16)

#1 @johnjamesjacoby
5 years ago

  • Description modified (diff)

#2 @johnjamesjacoby
5 years ago

In 9639:

XProfile: First pass at refreshing the the "Profile Fields" UI to better match current WordPress design direction.

Likely more iteration needed here, as everyone is a critic. See #6318.

#3 @hnla
5 years ago

as everyone is a critic

No not at all!

So the tab-throb?

Drag and drop between groups via tab - be nice if that was clearer, somehow, not sure how and played around for a short while with it.

Would be nice to have a little opacity levelled at the dragged .drop-candidate

@hnla
5 years ago

zero is zero

#4 @hnla
5 years ago

Or we could add a touch of opacity and have another keyframe colour setup to cut in when tab receives 'drop-candidate' class and change the throb to red to highlight a change state.

@hnla
5 years ago

Add tab animation colour change and opacity

#5 @johnjamesjacoby
5 years ago

In 9647:

XProfile: Update droppable field-group tab UI thobber styling to better indicate drag & dropping is possible. Props hnla. See #6318.

This ticket was mentioned in Slack in #buddypress by jjj. View the logs.


5 years ago

#7 @imath
5 years ago

Just tested, this is pretty nice, i love it :)

#8 @johnjamesjacoby
5 years ago

In 9667:

XProfile: Improvements to BP_XProfile_Field:

  • PHPDoc all variables and methods
  • Simplify verbiage for visibility metaboxes
  • Remove redundant "Field" verbiage in metabox titles
  • Introduce methods for outputting each individual metabox
  • Move "Required" metabox to sidebar (for improved symmetry)
  • Audit method parameters and ensure types and default values match what is expected in the call-stack
  • Remove unused $message variables from class
  • Stylistic tweaks to remove bottom margin from primary name & description area

See #6318.

#9 @johnjamesjacoby
5 years ago

In 9668:

XProfile: Improvemets to bp-xprofile-admin.php

  • Introduce xprofile_admin_screen() for outputting the root admin screen content
  • Add brackets to conditional statements
  • Add @todo regarding feedback message (kvetch)

See #6318.

#10 @johnjamesjacoby
5 years ago

In 9671:

XProfile: Improvemets to BP_XProfile_Group:

  • PHPDoc all variables and methods
  • Remove extract() usage
  • Clean up code formatting
  • No functional changes at this time
  • Also small clean up to BP_XProfile_Field docs

See #6318.

#11 @johnjamesjacoby
5 years ago

In 9673:

XProfile: Pass $type into xprofile_admin_screen(). See #6318.

#12 @DJPaul
4 years ago

@johnjamesjacoby Is this ticket done?

#13 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.