Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#6299 closed defect (bug) (fixed)

'bp_last_activity' cachegroup should be global

Reported by: r-a-y Owned by:
Milestone: 2.2.2 Priority: normal
Severity: normal Version: 2.2
Component: Performance Keywords: has-patch
Cc:

Description

We missed adding the 'bp_last_activity' cachegroup as a global group in #5733.

Attachments (1)

6299.01.patch (329 bytes) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (8)

@r-a-y
6 years ago

#1 @johnjamesjacoby
6 years ago

Good catch r-a-y. I vote we fast track this to 2.2.2 since it's a small fix on a common query.

How did you find this? Did you notice cached results between blogs had duplicate entries, or did you find it sifting through the code base?

#2 @r-a-y
6 years ago

Did you notice cached results between blogs had duplicate entries, or did you find it sifting through the code base?

Noticed cache invalidation issues with the last activity timestamp when a member is active on a sub-site and the 'bp_last_activity' cache was being cleared on the sub-site, but not the BP root blog.

To duplicate:

  1. Use an object cache.
  2. Add the members widget to the root blog and to a sub-site.
  3. Login as a member on the root blog to generate some activity. Wait five minutes, then go to a sub-site to update the last activity timestamp. This is triggered by bp_core_record_activity() on the 'wp_head' hook.
  4. For the members widget on the root blog, the last activity timestamp will use the older timestamp. For the members widget on the sub-site, the last activity timestamp will use the latest timestamp.

#3 @johnjamesjacoby
6 years ago

That's what I was imagining. Thanks for confirming.

#4 @johnjamesjacoby
6 years ago

In 9626:

Members: Add missing bp_last_activity cache group to BP_Members_Component.

Fixes regression introduced as part of #5733. See #6299. Props r-a-y. (trunk)

#5 @johnjamesjacoby
6 years ago

In 9627:

Members: Add missing bp_last_activity cache group to BP_Members_Component.

Fixes regression introduced as part of #5733. See #6299. Props r-a-y. (2.2 branch)

#6 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed. Thanks again r-a-y.

#7 @DJPaul
4 years ago

  • Component changed from API - Cache to Performance
Note: See TracTickets for help on using tickets.