Admin toolbar avatar wrong when visiting WP admin's options-discussion.php page

[henry.wright]

Inside bp_core_fetch_avatar_filter() there is:

// Do not filter if inside WordPress options page
if ( 'options-discussion.php' == $pagenow )
    return $avatar;

This causes an issue when viewing the options-discussion.php in the WP admin area.

Steps to reproduce:

1. Upload a profile photo via /change-avatar/
2. Visit the WP admin area, navigate around, and keep a close eye on your profile photo in the admin toolbar (top right-hand corner of the screen). You'll notice the profile photo displays nicely until you get to the options-discussion.php page (at which point you'll see something like the mystery person).

[Mamaduka]

@herny.wright

If we don't bail on discussion page, filter will break select "Default Avatar" setting and display BP avatar for every option. I think better solution will be to add BP avatar as an option to Default Avatar and respect users choice.

[henry.wright]

@Mamaduka

I'm not sure I agree an option for BP avatars under Default Avatar is a good idea. As a user, if I upload a profile photo then I expect it to display regardless of my 'default avatar' choice. The purpose of the 'default avatar' choice is set a fallback (for when there's no profile photo).

[DJPaul]

This might be tricky to fix. I think we'd likely need to use a particular hook to unregister our filter after we've drawn the toolbar but before the avatar list on the page.

[henry.wright]

This might be tricky to fix. I think we'd likely need to use a particular hook to unregister our filter after we've drawn the toolbar but before the avatar list on the page

Those were my thoughts too. But now get_avatar() accepts $args, this can be done fairly easily (see attached patch).

The catch is it'll also require a WordPress patch (which I'll submit separately and add a link here) so please don't commit this unless the WP patch is accepted.

[henry.wright]

See ​#34744 for the necessary WP changes I mentioned in my last comment.

[swissspidy]

This will be fixed in WordPress 4.6, see ​https://core.trac.wordpress.org/changeset/37227

[DJPaul]

@henry.wright Do you want to re-check this issue on WP 4.6 RC and see if it's been fixed for us? :)

[henry.wright]

@DJPaul sure. I'll write back once tested.

[henry.wright]

@DJPaul Tested 6298.diff against WP 4.6 RC 1. Works great. Thanks @swissspidy

[DJPaul]

Neat!

[swissspidy]

@DJPaul No commit in BuddyPress needed to fix this?

[mercime]

@DJPaul patch for your commit :)

[r-a-y]

In 11194:

Avatars: Fix issue with wrong avatar showing in the WP Toolbar when on the "Settings > Discussion" page.

Props henry.wright, swissspidy.

Hat-tip mercime for finding out that this ticket was closed without being
committed :)

Fixes #6298.