Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6290, comment 42


Ignore:
Timestamp:
04/08/2015 03:44:13 PM (5 years ago)
Author:
imath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6290, comment 42

    initial v1  
    33These last 2 days i had a fight with Internet Explorer 8, testing the patch in it. In the end, i don't know if i should kill him or kiss him!
    44
    5 So 6290.09.patch is bringing compatibility with IE8, improving our BuddyPress plupload file and revealing a problem in the {{{bp_core_check_avatar_type()}}}.
     5So [https://buddypress.trac.wordpress.org/attachment/ticket/6290/6290.09.patch 6290.09.patch] is bringing compatibility with IE8, improving our BuddyPress plupload file and revealing a problem in the {{{bp_core_check_avatar_type()}}}.
    66
    77How works plupload ? You set the available runtimes in your script, that's what we're doing in {{{bp_attachments_get_plupload_default_settings()}}} and the library will use the first runtime available. So far as i've tested in Chrome/Safari and Firefox, i was always getting the html5 runtime. But with my tests in IE8, once i've resolved some javascript issues (that was the most painful 2 days of my coding life!), i've found that, as we are falling back on the flash runtime, the {{{bp_core_check_avatar_type()}}} keeps on returning a file extension error despite the file is a jpg, png or gif image. I then checked in Chrome by disabling html5 and the same issue showed up.