Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6278, comment 6


Ignore:
Timestamp:
03/04/2015 07:10:46 PM (5 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6278, comment 6

    initial v1  
    11[https://buddypress.trac.wordpress.org/attachment/ticket/6278/6278.02.patch 6278.02.patch] roughly (and incompletely) implements a number of my above feedbacks. Patch is intended to be iterated upon and cleaned up.
    22
     3I also did a few other things that maybe are mistakes:
     4
     5* removed the `$component` variable since it's no longer a requirement
     6* use the `$action` variable where `$component` used to be used for namespacing
     7* Added `test_form` to `wp_handle_upload()` overrides, so form submission works
     8* Added `create_dir` method to encapsulate directory creation and whether it's necessary
     9* Removes `wp_mkdir_p()` usages and cleans up related `upload_dir` filters
     10* A bunch of other random surrounding cleanup I don't have time this minute to finish typing up here. :/
     11
    312@imath - sorry if I've duplicated your efforts. I didn't see the notification about your reply until just now, hence me uploading this (kind of incomplete) patch sooner than later.