Changes between Initial Version and Version 1 of Ticket #6278, comment 58
- Timestamp:
- 03/28/2015 07:11:55 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #6278, comment 58
initial v1 18 18 * `BP_Attachment_Extend` doesn't make sense to me as a class name for the unit tests. I suggest something like `BP_Tests_Attachment`??. 19 19 * Do we really need to upload files in our unit tests and write them to disk? It will be slow. Can't we just fake some data to pretend that has happened? 20 * The `rrmdir` function would be go in the base `BP_UnitTestCase` to avoid duplicating them.20 * The `rrmdir` function would best go in the base `BP_UnitTestCase` to avoid duplicating them. 21 21 * For `test_bp_upload_dir_ms`, please see #6162. 22 22 * The more mime type handlers we have to write, the more unit tests I want for them. If we can use WP's functions here, I don't mind not having unit tests for them.