Context Navigation

Changes between Version 3 and Version 4 of Ticket #6278, comment 4

v3	v4
16	16	* One thing Boone eluded to, but did not explicitly point out, is by encapsulating variables and methods in the classes, we avoid passing `$upload_dir_filter` around into the `upload()` method. `bp_core_avatar_handle_upload()` would need to stay how you've patched it for backpat.
17	17	* Maybe we should add a note to the `bp_attachment_upload_dir` filter pointing out that it's only for short-circuiting rather than extending. I can envision someone less familiar with OOP thinking they just hook in there and more easily introduce new upload paths.
18		* Should we be calling `remove_all_filters( 'upload_dir' )` in our `upload()` method? This filter makes me nervous since so many things touch it, that I'm afraid something else will be hooked in and break it.
	18	* Should we be calling `remove_all_filters( 'upload_dir' )` in our `upload()` method? This filter makes me nervous since so many things touch it, that I'm afraid something else will be hooked in and break it. Do we need to do the `switch_to_blog()`dance?
19	19
20	20	More specific feedback about `BP_Attachment_Avatar`: