Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6278, comment 38


Ignore:
Timestamp:
03/16/2015 02:16:54 PM (5 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6278, comment 38

    initial v1  
    11This is looking great. Agree with Paul some more general cleanup should happen once it drops.
    22
    3 The only thing I can think of to think more intently about is whether the crop method belongs in the Avatar class, or if it should be available to all Attachments as a general utility.
     3The only thing I see to think more intently about is whether the crop method belongs in the Avatar class, or if it should be available to all Attachments as a general utility.
     4
     5The same will probably go for any of our image editing utilities. Thinking future enhancements like tagging members in photos, facial recognition, etc… These types of utilities could also eventually grow into their own tools with their own classes, if they aren't already. I guess what I'm saying is, let's be sure we are deliberate with what functionality we empower what classes with.