Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6278, comment 25


Ignore:
Timestamp:
03/15/2015 01:16:11 AM (5 years ago)
Author:
henry.wright
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6278, comment 25

    initial v1  
    33I just took a look through 6278.06.patch, the whole approach is getting me excited. I love how the intention is for the base class to be extended, that opens up lots of development possibilities.
    44
    5 One thought, {{{create_dir()}}} is called each time an object is created. Could directory creation be moved to the BP plugin activation routine? That will avoid having to check if the upload path exists each time. But then on second thoughts, there's always to issue of the webmaster manually deleting the directory which could cause problems if there's no {{{wp_mkdir_p()}}} to make things right again.
     5One thought, {{{create_dir()}}} is called each time an object is created. Could directory creation be moved to the BP plugin activation routine? That will avoid having to check if the upload path exists each time. But then on second thoughts, there's always the issue of the webmaster manually deleting the directory which could cause problems if there's no {{{wp_mkdir_p()}}} to make things right again. Not sure what is best?