Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6277 closed defect (bug) (fixed)

Group admin counts are empty using WordPress 4.2 trunk

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.2.2 Priority: high
Severity: normal Version: 1.7
Component: Groups Keywords: has-patch
Cc:

Description

Related to changes in [WP31146] & #WP30891.

To Duplicate:

  • WordPress 4.2 (trunk at this time)
  • Enable Groups
  • Visit Groups admin
  • Create groups with varying statuses (public/private/hidden)
  • All counts are 0

Attachments (1)

6277.01.patch (418 bytes) - added by johnjamesjacoby 5 years ago.
Define $group_type_ids

Download all attachments as: .zip

Change History (9)

#1 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to 2.2.2
  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

Now that WordPress's WP_List_Table has a whitelist of allowed variables, its magic methods do not return any results (resulting in a null value) for any undefined class variables in any child classes of WP_List_Table. In this case, BP_Groups_List_Table->group_type_ids is not defined.

I'm putting this in the 2.2.2 milestone to start, since WordPress 4.2 will be out before 2.3.

If more investigation is necessary, we can bump this to 2.2.3 and beyond.

@johnjamesjacoby
5 years ago

Define $group_type_ids

#2 @johnjamesjacoby
5 years ago

  • Keywords has-patch added

#3 @johnjamesjacoby
5 years ago

In 9590:

Groups: define $group_type_ids in BP_Groups_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing our group status counts to always return "0" even when groups exist.

See #6277 (trunk)

#4 @johnjamesjacoby
5 years ago

In 9591:

Groups: define $group_type_ids in BP_Groups_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing our group status counts to always return "0" even when groups exist.

See #6277 (2.2 branch)

#5 @johnjamesjacoby
5 years ago

In 9592:

Activity: define $disable_blogforum_comments in BP_Activity_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing activity comment functionality to always return "null" even when enabled.

See #6277 (2.2 branch)

#6 @johnjamesjacoby
5 years ago

In 9593:

Activity: define $disable_blogforum_comments in BP_Activity_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing activity comment functionality to always return "null" even when enabled.

See #6277 (trunk)

#7 @johnjamesjacoby
5 years ago

BP_Members_List_Table and BP_Members_MS_List_Table both look okay.

I see no other List Table usages or problems, so closing as fixed.

Please reopen if anything changes between today and WordPress 4.2 release.

#8 @johnjamesjacoby
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.