Group admin counts are empty using WordPress 4.2 trunk

[johnjamesjacoby]

Related to changes in ​[WP31146] & ​#WP30891.

To Duplicate:

• WordPress 4.2 (trunk at this time)
• Enable Groups
• Visit Groups admin
• Create groups with varying statuses (public/private/hidden)
• All counts are 0

[johnjamesjacoby]

Now that WordPress's WP_List_Table has a whitelist of allowed variables, its magic methods do not return any results (resulting in a null value) for any undefined class variables in any child classes of WP_List_Table. In this case, BP_Groups_List_Table->group_type_ids is not defined.

I'm putting this in the 2.2.2 milestone to start, since WordPress 4.2 will be out before 2.3.

If more investigation is necessary, we can bump this to 2.2.3 and beyond.

[johnjamesjacoby]

Define $group_type_ids

[johnjamesjacoby]

In 9590:

Groups: define $group_type_ids in BP_Groups_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing our group status counts to always return "0" even when groups exist.

See #6277 (trunk)

[johnjamesjacoby]

In 9591:

Groups: define $group_type_ids in BP_Groups_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing our group status counts to always return "0" even when groups exist.

See #6277 (2.2 branch)

[johnjamesjacoby]

In 9592:

Activity: define $disable_blogforum_comments in BP_Activity_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing activity comment functionality to always return "null" even when enabled.

See #6277 (2.2 branch)

[johnjamesjacoby]

In 9593:

Activity: define $disable_blogforum_comments in BP_Activity_List_Table class.

While it's generally good to be explicit, this also addresses a compatibility issue with changes to WP_List_Table (in what will be WordPress 4.2) causing activity comment functionality to always return "null" even when enabled.

See #6277 (trunk)

[johnjamesjacoby]

BP_Members_List_Table and BP_Members_MS_List_Table both look okay.

I see no other List Table usages or problems, so closing as fixed.

Please reopen if anything changes between today and WordPress 4.2 release.