Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6270 closed defect (bug) (fixed)

"bp_message_add_meta()" should be "bp_messages_add_meta()"

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.2.2 Priority: high
Severity: minor Version: 2.2
Component: Messages Keywords: has-patch
Cc:

Description

We introduced private message meta in 2.2.0, but somehow missed that bp_message_add_meta() should have been bp_messages_add_meta() to match all of our other meta functions.

Attachments (3)

6270.01.patch (628 bytes) - added by johnjamesjacoby 5 years ago.
Rename
6270.02.patch (1.3 KB) - added by boonebgorges 5 years ago.
6270.03.patch (1.2 KB) - added by johnjamesjacoby 5 years ago.
For 2.2.2

Download all attachments as: .zip

Change History (13)

#1 @johnjamesjacoby
5 years ago

I highly doubt anyone is using this yet, so we can probably just rename it, or we could obviously wrap it if there's concerns.

@johnjamesjacoby
5 years ago

Rename

#2 @johnjamesjacoby
5 years ago

  • Keywords has-patch added

#3 @boonebgorges
5 years ago

  • Keywords 2nd-opinion removed

We should deprecate, just to be safe. 6270.02.patch

#4 follow-up: @DJPaul
5 years ago

We need to put bp_message_add_meta in the 2.2 deprecation file if we want this in 2.2.2 (which I think we should do).

#5 @r-a-y
5 years ago

Gosh darn it. I suck.

Like JJJ, I find it highly unlikely that someone is using add_meta() instead of update_meta(), but I understand the concerns of those already using it.

#6 in reply to: ↑ 4 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

Replying to DJPaul:

We need to put bp_message_add_meta in the 2.2 deprecation file if we want this in 2.2.2 (which I think we should do).

Agree. I'll take care of it.

Gosh darn it. I suck. Like JJJ, I find it highly unlikely that someone is using add_meta() instead of update_meta(), but I understand the concerns of those already using it.

No you don't. These types of mistakes are easy to make (especially for us where there are already lots of these kinds of inconsistencies) and one of us should have caught it before 2.2 went out, myself specifically since I packaged it up.

I'll take care of updating the patch and getting this in for 2.2.2. Thanks everyone for chiming in so quickly.

@johnjamesjacoby
5 years ago

For 2.2.2

#7 @johnjamesjacoby
5 years ago

In 9581:

Messages: rename bp_message_add_meta() to bp_messages_add_meta() to better match other metadata functions. See #6270 (trunk)

#8 @johnjamesjacoby
5 years ago

In 9582:

Derped the @deprecated version. See #6270 & r9581.

#9 @johnjamesjacoby
5 years ago

In 9583:

Messages: rename bp_message_add_meta() to bp_messages_add_meta() to better match other metadata functions. See #6270 (2.2 branch)

#10 @johnjamesjacoby
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Closing as fixed. Thanks again, everyone.

Note: See TracTickets for help on using tickets.