"bp_message_add_meta()" should be "bp_messages_add_meta()"

[johnjamesjacoby]

We introduced private message meta in 2.2.0, but somehow missed that bp_message_add_meta() should have been bp_messages_add_meta() to match all of our other meta functions.

[johnjamesjacoby]

I highly doubt anyone is using this yet, so we can probably just rename it, or we could obviously wrap it if there's concerns.

[johnjamesjacoby]

Rename

[boonebgorges]

We should deprecate, just to be safe. 6270.02.patch​

[DJPaul]

We need to put bp_message_add_meta in the 2.2 deprecation file if we want this in 2.2.2 (which I think we should do).

[r-a-y]

Gosh darn it. I suck.

Like JJJ, I find it highly unlikely that someone is using add_meta() instead of update_meta(), but I understand the concerns of those already using it.

[johnjamesjacoby]

Replying to DJPaul:

We need to put bp_message_add_meta in the 2.2 deprecation file if we want this in 2.2.2 (which I think we should do).

Agree. I'll take care of it.

Gosh darn it. I suck. Like JJJ, I find it highly unlikely that someone is using add_meta() instead of update_meta(), but I understand the concerns of those already using it.

No you don't. These types of mistakes are easy to make (especially for us where there are already lots of these kinds of inconsistencies) and one of us should have caught it before 2.2 went out, myself specifically since I packaged it up.

I'll take care of updating the patch and getting this in for 2.2.2. Thanks everyone for chiming in so quickly.

[johnjamesjacoby]

For 2.2.2

[johnjamesjacoby]

In 9581:

Messages: rename bp_message_add_meta() to bp_messages_add_meta() to better match other metadata functions. See #6270 (trunk)

[johnjamesjacoby]

In 9582:

Derped the @deprecated version. See #6270 & r9581.

[johnjamesjacoby]

In 9583:

Messages: rename bp_message_add_meta() to bp_messages_add_meta() to better match other metadata functions. See #6270 (2.2 branch)

[johnjamesjacoby]

Closing as fixed. Thanks again, everyone.