Skip to:

Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#6257 closed enhancement (fixed)

Notification Meta

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.3 Priority: high
Severity: normal Version: 1.8
Component: Toolbar & Notifications Keywords:


Notifications do not currently have a metadata table, which could be useful for storing additional data outside the available notification table's schema.

With the work that's gone into metadata interoperability and caching, this should be a fairly straightforward task.

Attachments (1)

6257.01.patch (9.7 KB) - added by johnjamesjacoby 9 years ago.
First pass - no unit tests

Download all attachments as: .zip

Change History (13)

#1 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

9 years ago

First pass - no unit tests

#2 @johnjamesjacoby
9 years ago

In 9572:

Notifications: Introduce notification metadata table.

  • Bump DB version
  • Introduce DB upgrade function & routine for 2.3.0
  • Add metadata table to Notifications installation function
  • Add metadata CRUD functions to Notifications component

See #6257.

#3 @johnjamesjacoby
9 years ago

In 9573:

Notifications: Add table_name_meta to global tables in loader. See #6257.

#4 @johnjamesjacoby
9 years ago

In 9574:

Notifications: Wire up meta queries so they return accurate results, largely lifted from Activity component. More to fine-tune here. See #6257.

#5 @johnjamesjacoby
9 years ago

In 9613:

Notifications: incorporate meta query logic into get_total_count() method. See #6257.

#6 @johnjamesjacoby
9 years ago

In 9614:

Always 80. See #6257.

#7 @johnjamesjacoby
9 years ago

In 9615:

Notifications. Bump database version to current revision, and add some inline docs to version updaters. See #6257.

#8 @johnjamesjacoby
9 years ago

Feature is in. Test coverage will get committed to this ticket as well.

#9 @DJPaul
9 years ago

@johnjamesjacoby Did unit tests ever happen, or shall we open a new ticket for that part, and aim them for 2.4?

#10 @johnjamesjacoby
9 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from accepted to closed

No tests yet. I started writing them and noticed that Activity and Notifications work a little differently now, and got side tracked.

I'm fine with closing this and making a new ticket for tests in 2.4.

#11 @r-a-y
8 years ago

In 10789:

Notifications: Update meta cache in BP_Notifications_Notification::get().

We update the meta cache if update_meta_cache is true, which it is by
default. Commit also updates the DocBlock to outline a few missing

See #6257, #7067.

#12 @r-a-y
6 years ago

In 11840:

Notifications: Fix date querying in bp_has_notifications().

Previously, we introduced the ability to query notifications by date with
the 'date_query' parameter in r9574. However, the DB column used for the
date query is incorrect.

See #6257.

Fixes #7682.

Note: See TracTickets for help on using tickets.