Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#6256 closed defect (bug) (fixed)

Add PHP7 support to travisci config.

Reported by: tw2113's profile tw2113 Owned by: boonebgorges's profile boonebgorges
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Cc:

Description

As per ​https://github.com/travis-ci/travis-ci/issues/2480#issuecomment-75988205, TravisCI now supports testing against PHP7.

This patch will add 7 to the list of supported versions to test against.

Attachments (3)

buddypress-php7-6256.diff​ (337 bytes) - added by tw2113 11 years ago.
buddypress-php7-6256.2.diff​ (525 bytes) - added by tw2113 11 years ago.
buddypress-php7-6256.3.diff​ (403 bytes) - added by tw2113 11 years ago.

Download all attachments as: .zip

Change History (15)

@tw2113
11 years ago

#1 @tw2113
11 years ago

  • Keywords has-patch added

#3 @DJPaul
11 years ago

  • Component changed from API to Tools - Build Process
  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 2.3

Make it like this ​https://buddypress.trac.wordpress.org/changeset/8392/trunk/.travis.yml so PHP 7 tests can fail without failing the whole suite, just in case PHP 7 turns out to have issues.

#4 @tw2113
11 years ago

Will amend and re-submit, thanks for the feedback :)

@tw2113
11 years ago

#5 @tw2113
11 years ago

Updated to allow failure for the 7/nightly build, and added a trailing .0 so that we can have more assured version checking in the future.

#6 @tw2113
11 years ago

  • Keywords has-patch added; needs-patch removed

#7 @netweb
11 years ago

Related: ​#WP31454

The 7 / 7.0 is an alias of nightly, I think we should use as WordPress Core plans and use nightly rather than 7/7.0.

Once PHP 7 is released then adding as a PHP version 7.0 to the build matrix and retaining the "allowed to fail" nightly would be the way to go.

Travis CI Docs reference: ​http://docs.travis-ci.com/user/languages/php/#PHP-nightly-builds

@tw2113
11 years ago

#8 follow-up: @tw2113
11 years ago

As per Stephen's feedback and copying his bbPress patch as best I could, revision 3 attempt :)

#9 in reply to: ↑ 8 @netweb
11 years ago

Replying to tw2113:

As per Stephen's feedback and copying his bbPress patch as best I could, revision 3 attempt :)

Perfect :)

Reference:

#10 @DJPaul
11 years ago

  • Keywords commit added

#11 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9560:

Add PHP nightly build as an allowed failure in Travis CI test matrix.

Props tw2113, netweb.
Fixes #6256.

#12 @DJPaul
10 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.