Skip to:
Content

BuddyPress.org

Opened 5 years ago

Last modified 3 years ago

#6235 closed defect (bug)

Widget labels not selecting inputs when clicked. — at Version 5

Reported by: tw2113 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch good-first-bug
Cc: alexander.berthelsen@…

Change History (5)

#1 @hnla
5 years ago

Patch then! You can also commit :)

The 'for' attr is best used regardless of whether there is 'implicit' or 'explicit' association in play.

Looking at the members widget I would only be worrying that the input ID was being used somehow/somewhere so would be copying that over to the 'for' attr replacing the static text string.

It's a shame about those input ID's they don't look the best, but risky to improve them, and the members filtered default to show is missing an ID altogether.

#2 @DJPaul
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Version 2.2.1 deleted

#3 @lakrisgubben
4 years ago

  • Cc alexander.berthelsen@… added

all of this seems to have been solved by: #6624 #6623 #6625

This ticket was mentioned in Slack in #buddypress by tw2113. View the logs.


4 years ago

#5 @tw2113
4 years ago

  • Description modified (diff)

@lakrisgubben Good catch. I've confirmed that all the label elements properly select the inputs now.

Thanks

Note: See TracTickets for help on using tickets.