Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#6235 closed defect (bug) (fixed)

Widget labels not selecting inputs when clicked.

Reported by: tw2113 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch good-first-bug
Cc: alexander.berthelsen@…

Description (last modified by tw2113)

The following widgets have labels and the appropriate tags associated with them, however the IDs that the labels are indicated aren't matching up like they should be, preventing the selection of the inputs. This is true even though the labels completely wrap the input, leaning towards precedence for the for attribute.

Friends
Groups
Members
Recently Active Members
Who's online.

Change History (8)

#1 @hnla
5 years ago

Patch then! You can also commit :)

The 'for' attr is best used regardless of whether there is 'implicit' or 'explicit' association in play.

Looking at the members widget I would only be worrying that the input ID was being used somehow/somewhere so would be copying that over to the 'for' attr replacing the static text string.

It's a shame about those input ID's they don't look the best, but risky to improve them, and the members filtered default to show is missing an ID altogether.

#2 @DJPaul
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Version 2.2.1 deleted

#3 @lakrisgubben
4 years ago

  • Cc alexander.berthelsen@… added

all of this seems to have been solved by: #6624 #6623 #6625

This ticket was mentioned in Slack in #buddypress by tw2113. View the logs.


4 years ago

#5 @tw2113
4 years ago

  • Description modified (diff)

@lakrisgubben Good catch. I've confirmed that all the label elements properly select the inputs now.

Thanks

#6 @tw2113
4 years ago

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed

#7 @netweb
4 years ago

  • Milestone Future Release deleted

#8 @DJPaul
3 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.