Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6223 closed defect (bug) (fixed)

Remove failing automated tests from the suite

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description

See https://core.trac.wordpress.org/ticket/30284

A normal run of phpunit currently skips test that are annotated with @ticket BP12345 if ticket 12345 is open. This practice has some negative consequences, especially because it forces a number of *passing* tests to be skipped. (Also, this behavior requires a ping to Trac, which causes issues like those described in #5910 [9053].)

We should remove failing tests and stop skipping them when running phpunit. We should also agree to stop committing failing tests to the repo. Commit only those tests that pass, and leave failing tests as patches on the corresponding tickets. Those tests will then be committed with their corresponding fixes.

Change History (3)

#1 @boonebgorges
5 years ago

In 9480:

Remove failing test from repo.

This test is the only one that fails in all of our phpunit tests. It's been
added as a patch to the ticket to which it belongs, #5874.

See #6223.

#2 @boonebgorges
5 years ago

In WP, we did something pretty arcane to ensure that Trac-checking still worked for plugins that use WP_UnitTestCase (like BuddyPress!). See https://core.trac.wordpress.org/changeset/30526 I don't think a similar strategy is necessary for us, as it's likely that the only person who's ever used BP_UnitTestCase outside of BP is me, and I'm not depending on the Trac-checker. So I'm going to tear it out. If we get reports that third-party plugin tests are failing, we can put it back. (I'm not holding my breath.)

#3 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9481:

Stop skipping tests attached to unclosed Trac tickets.

Fixes #6223.

Note: See TracTickets for help on using tickets.