Audit filters in core widgets to ensure they meet WordPress expectations

[dcavins]

Bowe pointed out via Slack that he was having trouble applying the filter widget_title to the BP members widget.

The problem is that that widget isn't providing the expected parameters to the filter.

From BP members widget:
$title = apply_filters( 'widget_title', $instance['title'] );

The parameters expected in widget_title are
$title = apply_filters( 'widget_title', $instance['title'], $instance, $this->id_base );

I'd be happy to complete the audit and write patches if someone will assign it to me.

[dcavins]

I've added the necessary arguments. I think this (simple) patch should be ready to go but would appreciate another set of eyes on my changes.

[boonebgorges]

This looks good, dcavins.

[dcavins]

Add arguments to 'widget_title' filter. Add $instance settings and $id_base to the arguments passed along with the ‘widget_title’ filter for BP core widgets.

[dcavins]

In 9709:

Add arguments to 'widget_title' filter.

Add $instance settings and $id_base to the arguments passed along with the
'widget_title' filter for BP core widgets.

Fixes #6222.

[dcavins]

Verify that title is set before widget_title filter.
Use calculated value in filter. Be sure that the title value is set before passing to the filter. See #6222.

[dcavins]

Attached a second patch that reverts three instances of using the raw title attribute rather than a calculated title attribute and makes sure that the value is set in three other cases before sending it out to the filter.

[dcavins]

In 9738:

Use calculated title for widget_title filter.

Use the calculated title when one exists in 'widget_title' filter.

See #6222.