Opened 11 years ago
Closed 11 years ago
#6207 closed defect (bug) (fixed)
BP user blogs count display in user nav not classed.
| Reported by: | hnla | Owned by: | johnjamesjacoby |
|---|---|---|---|
| Priority: | low | Milestone: | 2.3 |
| Component: | Blogs | Version: | |
| Severity: | minor | Keywords: | has-patch early commit |
| Cc: |
Description
The user navs display counts in spans on various nav tabs e.g notifications, these span elements are classed either as 'no-count' or 'count'.
The Sites tab link has never had these classes added to it's span count.
This patch corrects this for uniformity.
@lead-devs please check this as I had to cast bp_get_total_blog_count_for_user as an '(int)' as in replicating other examples of how we do this a strict comparison is used but that failed on my re-working originally I used a < 1 as a check but wanted to mirror how the others handled it but 0=== failed when it shouldn't have, tracking the function back wasn't clear what the value being passed was. As it's a clear count it seemed appropriate to cast it to an int and it's use doesn't move outside the scope it's used in here.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Good fix for 2.3. Let's get this in early.