Displaying member types within members loop fails

[imath]

I've been pinged by this topic ​https://buddypress.org/support/topic/bp_get_member_type-is-not-working-in-the-loop/ then tried to understand what was going wrong.

I think the problem is due to the fact bp_members_prefetch_member_type() is caching a string and bp_get_member_type() needs an array as it uses array_pop()

So i suggest the attached patch to be sure to cache all potentiel member types assigned to a user.

[imath]

Sorry, i wasn't able to run the unit tests to check everything was ok, will do soon

[boonebgorges]

This definitely needs unit tests. Thanks for the catch.

[imath]

6193.unittests.patch only contains the unittests.

[boonebgorges]

Thanks, imath. Just to clarify a bit for posterity's sake: The 2.2 implementation of member type caches was meant to store arrays of member types; see bp_get_member_type() for an example. However, the prefetch function (and its unit test) was mistakenly written to cache string values.

I'm going to rewrite the logic here to be just a little bit less opaque, and fix it in trunk and on the branch.

[boonebgorges]

In 9447:

When prefetching member types in the loop, cache arrays instead of strings.

Member type caches should always be arrays of all member types for a user.

Props imath.
Fixes #6193.

[boonebgorges]

In 9448:

When prefetching member types in the loop, cache arrays instead of strings.

Member type caches should always be arrays of all member types for a user.

Props imath.
Fixes #6193 for the 2.2 branch.