Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#6186 closed defect (bug) (wontfix)

"id" definition missing on member index page (styling issue)

Reported by: yosmc's profile yosmc Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.2
Component: Templates Keywords:
Cc: hnla

Description

In line 17 on buddypress/bp-templates/bp-legacy/buddypress/members/index.php the "id" definition is missing. The line reads:

<div class="item-list-tabs" role="navigation">

Whereas it should read:

<div class="item-list-tabs" id="object-nav" role="navigation">

This is irrelevant as long as the standard styling is used or the custom styles use the same layout for both object-nav and subnav. If you choose to style the navigation levels differently, however, it breaks on this page as the correct id (being consistent with all other Buddypress pages) is missing.

Change History (5)

#1 @DJPaul
9 years ago

Hi yosmc,

Thanks for getting in contact. I'm not sure it's as consistent as you suggest, though I may be misunderstanding. This is what I find when I search across the project:

Searching 389 files for "id="object-nav" role="navigation""

/buddypress/src/bp-templates/bp-legacy/buddypress/groups/single/home.php:
   14: 		<div class="item-list-tabs no-ajax" id="object-nav" role="navigation">

/buddypress/src/bp-templates/bp-legacy/buddypress/members/single/home.php:
   12: 		<div class="item-list-tabs no-ajax" id="object-nav" role="navigation">


Searching 389 files for "<div class="item-list-tabs" role="navigation">"

/buddypress/src/bp-templates/bp-legacy/buddypress/blogs/index.php:
   14: 		<div class="item-list-tabs" role="navigation">

/buddypress/src/bp-templates/bp-legacy/buddypress/forums/index.php:
   20: 		<div class="item-list-tabs" role="navigation">

/buddypress/src/bp-templates/bp-legacy/buddypress/groups/index.php:
   17: 		<div class="item-list-tabs" role="navigation">

/buddypress/src/bp-templates/bp-legacy/buddypress/members/index.php:
   17: 		<div class="item-list-tabs" role="navigation">

#2 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to Under Consideration

#3 @DJPaul
9 years ago

  • Cc hnla added

@hnla can you take a look when you get some spare time? Non urgent. Just looking for feedback as to whether we should do exactly what the ticket says or not (unifying those other versions of this div is beyond scope of this ticket, at the moment) and you're closer to the templates than I am at the moment.

#4 @hnla
9 years ago

Thanks for reporting this yosmc.

Our Navs in respect of class & ID tokens are a little in need of review and updating.

However as Paul says we are sort of consistently inconsistent; in reality we do not use the ID 'object-nav' on any but the user account navigational elements on the parent navigation. The navigation you are referring to - the BP dir navs have only ever been classed with the global 'item-list-tabs' the awkward aspect is that we do then give all sub navigation elements the parent id '#subnav' so one has to be quite alert when adding and maintaining styles.

I think to try and rectify things for these templates is probably not the best use of time and resources, we do acknowledge the need, overall, to address templates though and it's then that we could have the opportunity to properly re-think these elements and perhaps update class names such as 'item-list-tabs' to be less about visual descriptive presentation probably something nearer to 'bp-nav-lists' which further more specific naming of navs within their context.

In addition we do have a navigational function that hasn't officially been used to date bp_nav_menu() but which exists and works and we may look at that in future template updates and this might help influence choice of id/class tokens.

Hopefully we might look at a fresh set of BP templates for 2.4 and navigational aspects like this will part of that review, and yours and others feedback when this is underway will be invaluable.

#5 @DJPaul
9 years ago

  • Milestone Under Consideration deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Based on hnla's feedback, let's leave this alone in BP-Legacy because it's been like this since forever, which makes it a risky change.

Note: See TracTickets for help on using tickets.