Usage of var keyword generates an E_STRICT warning when using PHP 5 before version 5.1.3

[henry.wright]

Should declarations that use the var keyword be changed to public? I think they're treated as such.

An example can be seen in the BP_Activity_Activity class.

[DJPaul]

Sure. As you probably know, var is left-over from PHP 4. I think PHP added the warning in 5.0-ish but then removed it in a 5.2-ish release, which is why we haven't seen this before.

We can fix these up because PHP4, but as WP requires PHP >= 5.2, you should upgrade to a modern version of PHP ;)

[henry.wright]

but as WP requires PHP >= 5.2, you should upgrade to a modern version of PHP ;)

Good advice :)

[henry.wright]

Just been through BP. These are the classes that are affected:

• BP_XProfile_Component

• BP_Activity_Activity

• BP_XProfile_Data_Template

• BP_Groups_Template

• BP_Groups_Group_Members_Template

• BP_Forums_Template_Forum

• BP_Forums_Template_Topic

• BP_Core_Members_Template

• BP_Activity_Template

[henry.wright]

This is most probably a very low priority ticket, but, attached is 6185.diff which should eradicate the E_STRICT warning.

[djpaul]

In 9515:

Replace use of PHP4-era var class properties keywords with public.

Also adds some phpDoc.

Fixes #6185, props henry.wright