Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6177, comment 5


Ignore:
Timestamp:
02/04/2015 10:41:02 AM (4 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6177, comment 5

    initial v1  
    11Thanks for taking a quick look, Boone. I really appreciate it.
    22
    3 I had done some testing using xhprof to performance test the unit tests I wrote. That revealed some useful areas of improvements, such as [https://github.com/paulgibbs/BuddyPress/commit/e3eab90dcd127a42eb5bc42eef5f6a802caf7b4c avoiding regex calls where possible]. In terms of how `bp_activity_create_summary` is currently, it's only used for Posts on the transition_post_status hook, which means it isn't being run at real-time.
     3I had done some testing using xhprof to performance test the unit tests I wrote. That revealed some useful areas of improvements, such as [https://github.com/paulgibbs/BuddyPress/commit/e3eab90dcd127a42eb5bc42eef5f6a802caf7b4c avoiding regex calls where possible] (I retested that assumption and found that it's still true). In terms of how `bp_activity_create_summary` is currently, it's only used for Posts on the transition_post_status hook, which means it isn't being run at real-time.
    44
    55Please would someone remind me what the change was to activity objects, I think in one of the last couple of versions? One of the fields were hardcoded (so they couldn't be translated? or something) and then we changed it so they were dynamically generated, which I assume is what Boone is getting at here.