Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#6172 closed enhancement (wontfix)

Blogs loop template li elements class attr hijacked by BP core

Reported by: hnla Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Templates Keywords: needs-patch
Cc:

Description

On the li children in the blogs loop the class attr has been commandeered by BP:
bp_blog_class()

This is to provide the looped entries with a zebra stripe class odd/even.

While nice and good to do the implementation leaves the frontend dev no room for modifying - yes there's a filter but a filter! the requirement is to add one simple string, a 2 sec job, rather than have to open another file write a function to filter that simple string in and have more code to support littered throughout various files.

All template functions such as this need to be parametrised, we need to be able to pass args over on any function such as this, or at least to the majority of them.

This has come up briefly before and iirc I've ticketed another instance along these lines that needs addressing.

We/I need to audit all of these where they may occur and update them to use bp_parse_args()

I'm willing to tackle this in 2.3 along with a few other templating concerns.

Change History (6)

#1 @johnjamesjacoby
5 years ago

  • Component changed from Component - Any/All to Appearance - Template Pack

#2 @DJPaul
4 years ago

  • Milestone changed from 2.3 to Future Release

#3 @DJPaul
4 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#4 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates

#5 @DJPaul
2 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#6 @DJPaul
2 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.