Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6140 closed defect (bug) (fixed)

Group activity failing to find /query group updates

Reported by: hnla's profile hnla Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.2 Priority: highest
Severity: blocker Version:
Component: Activity Keywords:
Cc:

Description

Posting an activity update in groups is initially seeming to be accepted and is displayed, however on subsequent returns to the group activity 'Home' we have the 'No Activity found' message so appears activity query is failing.

Activity update is correctly recoded and exists in activity admin records and is displayed in the primary activity stream suggesting an issue with querying for group id to exclusion of all else.

Change History (7)

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


9 years ago

#2 @johnjamesjacoby
9 years ago

Problem arises because the $scope when viewing a single group is "home" and not "groups" as it was coded to be.

#3 @johnjamesjacoby
9 years ago

Looks like bp_groups_filter_activity_scope() was supposed to pull double duty for two filters:

  • bp_activity_set_groups_scope_args
  • bp_activity_set_home_scope_args

The "home" one is scary, because of front.php, BP_GROUPS_DEFAULT_EXTENSION, and the bp_groups_default_extension filter.

#4 @boonebgorges
9 years ago

  • Component changed from Core to Activity
  • Milestone changed from Awaiting Review to 2.2
  • Severity changed from major to blocker

#5 @r-a-y
9 years ago

Thanks for the report, hnla.

I think the commit I added (r9330) overrides too many things. imath's patch in #6099 is more conservative and should address the issue.

Going to reopen #6099.

#6 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9372:

Revert r9330 in lieu of original patch on #6099.

When querying for various types and scopes of activity stream items, each BuddyPress component having a unique type or scope also has unique keys and filters responsible for handling the custom queries necessary to get the correct entries from the database.

In some instances (like single groups, member favorites, etc...) these scopes are returning invalid (or empty) results, causing no activity entries to be returned from the database when entries do exist and should be displayed.

Unit tests still apply (though they get some variable clean-up here.)

Hat-tip hnla for discovery. Props r-a-y, imath. Fixes #6140. Fixes #6099.

#7 @hnla
9 years ago

Can confirm it all seems to test as correct and work as expected.

Note: See TracTickets for help on using tickets.