Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 8 years ago

#6117 closed defect (bug) (wontfix)

form in form in bp-legacy template files

Reported by: lenasterg's profile lenasterg Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Templates Keywords: good-first-bug needs-patch
Cc:

Description

Hi.
I noticed that the positioning of:

and
-bp_directory_forums_search_form() in https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/forums/index.php#L11

are mispositioning Html form into form.
Althought this is not a usability issue and the pages are working correctly in browsers, the pages are not html valid.

Suggested changes in attached file.

Attachments (1)

bp-legacy.patch (1.7 KB) - added by lenasterg 9 years ago.

Download all attachments as: .zip

Change History (9)

@lenasterg
9 years ago

#1 @johnjamesjacoby
9 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.3

Can someone confirm ajax still works as expected after applying this patch?

#2 @DJPaul
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 @DJPaul
9 years ago

  • Keywords good-first-bug added
  • Milestone changed from 2.3 to 2.4

#4 @mercime
9 years ago

Just to note that the issue for bp-legacy/buddypress/blogs/index.php has been resolved in #6427

#5 @DJPaul
9 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

I think remaining work is to do the same as in #6427 for the legacy forums components.

#6 @DJPaul
8 years ago

  • Milestone changed from 2.4 to Future Release

#7 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#8 @DJPaul
8 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This relates to the legacy bp-forums templates which are no longer in use, so closing this ticket.

Note: See TracTickets for help on using tickets.