Skip to:

Opened 9 years ago

Closed 9 years ago

#6113 closed enhancement (fixed)

BP messages search form lacks filter for markup

Reported by: hnla's profile hnla Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Messages Keywords: has-patch needs-testing


The directory search filters have filters on the html markup however the bp-messages-template.php bp_messages_search_form() hasn't.

Patch adds filter.

I've re-factored the approach slightly as not a fan of trying to read through mixed php/html strings and have pulled out some conditionals to new variables as easier to deal with.

Approach may not find favour :) this is a rushed task as it was a blocker to some work I was doing so needs checking over carefully.

Attachments (1)

6113-01.patch (2.2 KB) - added by hnla 9 years ago.
Update message search for html filter

Download all attachments as: .zip

Change History (2)

9 years ago

Update message search for html filter

#1 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9349:

Improvements to bp_message_search_form():

  • Escape gettext output in form field elements.
  • Add filter to allow output to be manipulated.
  • Bring surrounding code up to current coding standards.

Props hlna. Fixes #6113.

Note: See TracTickets for help on using tickets.