Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

#6110 closed enhancement (fixed)

Provide user ID for bp_notifications_get_unread_notification_count filter

Reported by: tw2113 Owned by: tw2113
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Toolbar & Notifications Keywords: good-first-bug
Cc:

Description

Right now, we simply provide the count for the bp_notifications_get_unread_notification_count filter, but that's not enough to conditionally filter the count. It'd be best to also provide the ID of the user whose count is being filtered.

Attachments (1)

6110-userid-param.diff (892 bytes) - added by tw2113 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @tw2113
5 years ago

My mistake, bp_notifications_get_unread_notification_count is the function name, the filter needing the user ID is bp_notifications_get_total_notification_count

#2 @DJPaul
5 years ago

  • Component changed from Core to Notifications
  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

#3 @tw2113
3 years ago

  • Owner set to tw2113
  • Status changed from new to assigned

Easy fix. Assigning to self, pending approval.

#4 @tw2113
3 years ago

  • Milestone changed from Future Release to 2.7

#5 @tw2113
3 years ago

This is an easy one and shouldn't break any compatibility, but still want at least one a-okay.

#6 @DJPaul
3 years ago

Yep, as it's harmless.

#7 @tw2113
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11167:

Pass user ID value to bp_notifications_get_unread_notification_count filter for better conditional checking.

Fixes #6110.

Note: See TracTickets for help on using tickets.