Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6107, comment 26


Ignore:
Timestamp:
03/06/2015 10:25:28 AM (5 years ago)
Author:
imath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6107, comment 26

    initial v1  
    66 3. There are plugins that are filtering 'wp_title' without taking in account the filter BuddyPress is providing for its "pages" (in particular Yoast). This means our efforts to respect the WordPress way of building title using the 'wp_title_parts' filter would anyway & inevitably be cancelled by these plugins.
    77
    8 So 6170.04.patch is simplifying everything as it carries on filtering 'wp_title', changing the priority to '''20'''. I think we can act this late because we are taking care of checking the page that is loading is a BuddyPress page.
     8So [https://buddypress.trac.wordpress.org/attachment/ticket/6107/6107.04.patch 6170.04.patch] is simplifying everything as it carries on filtering 'wp_title', changing the priority to '''20'''. I think we can act this late because we are taking care of checking the page that is loading is a BuddyPress page.
    99
    1010I've tested it with twentyfifteen (which supports the title-tag feature) & twentytwelve (which is not supporting it and uses `twentytwelve_wp_title()` to filter 'wp_title') on WordPress trunk.