Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#6104 closed defect (bug) (fixed)

Grunt package.json - Bump CSSJanus dependency to latest version

Reported by: r-a-y's profile r-a-y Owned by: r-a-y's profile r-a-y
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

netweb found out that r9340 was due to the fact that I was running an older version of cssjanus (1.1.0), while the latest version (1.1.1) does not generate the change in r9340.

It would be better if grunt-cssjanus bumped their dependency for cssjanus (I've created a ticket for this on their GitHub repo), but I guess we can temporarily bump the cssjanus version to the latest in the meantime.

Attached patch does this.

Attachments (1)

6104.01.patch (318 bytes) - added by r-a-y 10 years ago.

Download all attachments as: .zip

Change History (10)

@r-a-y
10 years ago

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


10 years ago

#2 @netweb
10 years ago

I knew it would be something simple :/

In WordPress Core we're working to add some form of control to the NPM version dependancies #WP30787, once we've sorted it for Core I'll create patches for bbPress and BuddyPress.

+1 to commit this and once grunt-cssjanus have bumped their minimum CSSJanus dependancy this can be reverted.


This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


10 years ago

#4 follow-up: @johnjamesjacoby
10 years ago

Fixes it for me. Do we want to keep these alphabetical?

#5 in reply to: ↑ 4 @netweb
10 years ago

Replying to johnjamesjacoby:

Fixes it for me. Do we want to keep these alphabetical?

Yep, probably best to, either way it'll get reverted eventually ;)

#6 @johnjamesjacoby
10 years ago

In 9347:

Add cssjanus to package.json to ensure we use an up-to-date version until grunt-cssjanus gets an update. Props r-a-y. See #6104.

#7 @r-a-y
10 years ago

In 9348:

bp-legacy: Revert r9340.

This change was due to using an older version of CSSJanus (1.1.0). The
latest version of CSSJanus (1.1.1) does not create this change.

Props netweb.

See #6104.

#8 @r-a-y
10 years ago

grunt-cssjanus updated their cssjanus dependency to 1.1.1, so we can bump our cssjanus dependency now.

#9 @r-a-y
10 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9356:

Bump grunt-cssjanus dependency to 0.2.3.

This commit reverts our temporary addition to bump cssjanus to 1.1.1
(r9347) as grunt-cssjanus has updated their cssjanus dependency to
1.1.1.

Fixes #6104.

Note: See TracTickets for help on using tickets.