Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#6092 closed defect (bug) (fixed)

Lots of typos

Reported by: slaFFik Owned by:
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch dev-feedback
Cc: slaFFik

Description

In comments, strings that should be translated.

I'm working right now on a patch, want to find and fix them all.

Of course, I'm not touching functions names, filters etc - everything that can break compatibility.

Attachments (1)

6092.patch (71.7 KB) - added by slaFFik 6 years ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.


6 years ago

#2 @slaFFik
6 years ago

Like activty instead of activity.
Classes/variables names typos in phpdoc.
Lack of letters or spaces here and there.

Last edited 6 years ago by slaFFik (previous) (diff)

#3 @slaFFik
6 years ago

bp_is_user_recent_commments()
Used in 1 place only.
And several deprecated filters that I didn't touch.

@slaFFik
6 years ago

#4 @slaFFik
6 years ago

  • Keywords has-patch dev-feedback added
  • Milestone changed from Awaiting Review to 2.2

I also didn't touch pot file, as strings in it will be regenerated.

Last edited 6 years ago by slaFFik (previous) (diff)

#5 @r-a-y
6 years ago

Nice work, slaFFik.

I'm going to commit this without the widget JS function name changes from /bp-groups/js/ and /bp-friends/js/ because there might be some installs relying on the poorly-named JS function names. We can always come back to this later.

#6 @r-a-y
6 years ago

In 9308:

Fix all the typos.

Props slaFFik.

See #6092.

#7 @slaFFik
6 years ago

You meant 3 places? Core, friends and groups, right?
I see you missed this one: https://buddypress.trac.wordpress.org/changeset/9308#file29 - and it's in the repo now.

Last edited 6 years ago by slaFFik (previous) (diff)

#8 follow-up: @r-a-y
6 years ago

Darn, I committed the core members widget :(

Well, I guess it'd be a good time to get other dev's feedback on this :)

#9 in reply to: ↑ 8 @johnjamesjacoby
6 years ago

Replying to r-a-y:

Darn, I committed the core members widget :(

Well, I guess it'd be a good time to get other dev's feedback on this :)

May as well change it. I find it unlikely this will break too much, since if it's overridden, it's either a copy/paste or totally custom.

#10 @r-a-y
6 years ago

In 9319:

Fix typos in the Groups and Friends widget JS.

Props slaFFik.

See #6092.

#11 @r-a-y
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for your work on this ticket, slaFFik!

Going to close this one.

Note: See TracTickets for help on using tickets.