Opened 10 years ago
Closed 10 years ago
#6092 closed defect (bug) (fixed)
Lots of typos
Reported by: | slaFFik | Owned by: | |
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch dev-feedback |
Cc: | slaFFik |
Description
In comments, strings that should be translated.
I'm working right now on a patch, want to find and fix them all.
Of course, I'm not touching functions names, filters etc - everything that can break compatibility.
Attachments (1)
Change History (12)
This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.
10 years ago
#3
@
10 years ago
bp_is_user_recent_commments()
Used in 1 place only.
And several deprecated filters that I didn't touch.
#4
@
10 years ago
- Keywords has-patch dev-feedback added
- Milestone changed from Awaiting Review to 2.2
I also didn't touch pot file, as strings in it will be regenerated.
#5
@
10 years ago
Nice work, slaFFik.
I'm going to commit this without the widget JS function name changes from /bp-groups/js/
and /bp-friends/js/
because there might be some installs relying on the poorly-named JS function names. We can always come back to this later.
#7
@
10 years ago
You meant 3 places? Core, friends and groups, right?
I see you missed this one: https://buddypress.trac.wordpress.org/changeset/9308#file29 - and it's in the repo now.
#8
follow-up:
↓ 9
@
10 years ago
Darn, I committed the core members widget :(
Well, I guess it'd be a good time to get other dev's feedback on this :)
#9
in reply to:
↑ 8
@
10 years ago
Replying to r-a-y:
Darn, I committed the core members widget :(
Well, I guess it'd be a good time to get other dev's feedback on this :)
May as well change it. I find it unlikely this will break too much, since if it's overridden, it's either a copy/paste or totally custom.
Like
activty
instead ofactivity
.Classes/variables names typos in phpdoc.
Lack of letters or spaces here and there.