Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6090, comment 2


Ignore:
Timestamp:
01/07/2015 12:21:30 AM (9 years ago)
Author:
dcavins
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6090, comment 2

    initial v1  
    22Thanks for looking over the patch r-a-y.
    33
    4 I'm a bit worried about the use of `BP_Groups_Member::delete` in `groups_delete_membership_request()` because that will delete any record that involves the user and group, which could include any requests, invitations or memberships, right? In these functions, it follows the deletion of invitations while the group membership is being created, so I guess those other possible records are also being deleted. It's also used in `groups_reject_membership_request()` so it could potentially delete invitations as well as requests there.
     4I'm a bit worried about the use of `BP_Groups_Member::delete` in `groups_delete_membership_request()` because that will delete any record that involves the user and group, which could include any requests, invitations or memberships, right? In these functions, it follows the deletion of invitations while the group membership is being created, so I guess those other possible records are also being deleted anyway. It's also used in `groups_reject_membership_request()` so it could potentially delete invitations as well as requests there.
    55
    66Short of using `delete_request()`, I'm not sure how to prevent the function from being overzealous.