Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6087 closed defect (bug) (fixed)

Incorrect single private message thread description

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Priority: normal Milestone: 2.2
Component: Core Version:
Severity: normal Keywords: commit
Cc:

Description

When a member private messages themselves, they see a description that says:

"Conversation between and you."

single.php attempts to check ! bp_get_thread_recipients_count() but this doesn't account for 1 single person messaging themselves.

Attachments (1)

6087.patch​ (509 bytes ) - added by johnjamesjacoby 12 years ago.

Download all attachments as: .zip

Change History (5)

@johnjamesjacoby
12 years ago

This ticket was mentioned in ​Slack in #buddypress by jjj. ​View the logs.
12 years ago

#2 @boonebgorges
12 years ago

For the record: the logic in BP_Messages_Thread::get_recipients() ensures that the thread recipient count will correctly be 1 in cases like this, which means we can safely rely on it for a <= check.

Looks good to me.

#3 @johnjamesjacoby
12 years ago

  • Owner set to johnjamesjacoby
  • Resolution → fixed
  • Status new → closed

In 9296:

When a member sends themselves a private message (helpful for testing, mostly) ensure they see the appropriate description. Fixes #6087.

#4 @johnjamesjacoby
12 years ago

In 9407:

Update single message conversation verbiage in single.php. Fixes #6087 again, but better this time.

Note: See TracTickets for help on using tickets.