Incorrect results from xprofile_get_field_id_from_name( $field_name )

[dontdream]

When a field name and an option value are the same, the function

xprofile_get_field_id_from_name( $field_name )

may return the option ID instead of the desired field ID.

The attached patch restricts the search to rows with parent_id = 0.

[boonebgorges]

Good find. Let's get a unit test for it.

[r-a-y]

In 9324:

XProfile: Make sure xprofile_get_field_id_from_name() returns a field ID for a field name.

Previously, when using xprofile_get_field_id_from_name(), it was possible
to get the option ID instead of the desired field ID because a field name
and an option value (for a checkbox or radio field) can potentially be the
the same in the wp_bp_xprofile_fields DB table.

This commit ensures that field name look ups will return a field ID instead
of an option ID. Commit also includes a unit test.

Props dontdream.

Fixes #6082.